search

riverwanderer / ccnapoleonics

Commands & Colors: Napoleonics on vassalengine.org
https://boardgamegeek.com/boardgame/62222/commands-and-colors-napoleonics
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Board reset may start game in buildmode #248

Closed riverwanderer closed 3 months ago

riverwanderer commented 3 months ago

Module V5.1.0beta4 Vassal V3.7.14

Impacts on scenario designers. Board reset (F6) is used to clear mark moves. During work on GG00 a second use of it caused the game to start.

A workaround is to move pieces twice (second move will remove mark moves prior to game start).

riverwanderer commented 3 months ago

Confirmed for both new scenario and modifying existing. Occurs consistently from second press of F6. Also occurs in beta3, so not due to changes for #238. Note that observer role as well as other roles triggers this and observers should never be able to start a game or end a turn. Reproduces back to 5.0beta9 but not in v4.1.16.

riverwanderer commented 3 months ago

Cause is this use of EndTurn, which "works" first time through but triggers its normal, in-game, action on subsequent passes:

image

gPhase is being set to 5 which removes the control preventing a normal end turn.

riverwanderer commented 3 months ago

Fix in a602/