rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.
https://rizin.re
GNU Lesser General Public License v3.0
2.71k stars 363 forks source link

Rizin didn't detect the correct language of binary #878

Open Heersin opened 3 years ago

Heersin commented 3 years ago

Work environment

Questions Answers
OS/arch/bits (mandatory) Linux
File format of the file you reverse (mandatory) ELF
Architecture/bits of the file (mandatory) AMD x86-64 architecture
rizin -v full output, not truncated (mandatory) rizin 0.2.0

Expected behavior

Actual behavior

both print out the

lang     c

Steps to reproduce the behavior

related test

ada

fpc

XVilka commented 3 years ago

Please add a link to the test in the testsuite

Maijin commented 3 years ago

Hi @Heersin make sure you mock-up the tests when the current output is wrong and use BROKEN=1, otherwise it means that the current output is what is expected. Feel free to enhance it - just make sure not to put invalid output as non-broken 😄

Here is an example - https://github.com/rizinorg/rizin/pull/894

Heersin commented 3 years ago

Hi @Heersin make sure you mock-up the tests when the current output is wrong and use BROKEN=1, otherwise it means that the current output is what is expected. Feel free to enhance it - just make sure not to put invalid output as non-broken

Here is an example - #894

Sorry for my misuse of expect output, I would enhance them now. thanks to point it out with examples ~

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has probably changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of rizin. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.

Maijin commented 3 years ago

still accurate