search

rizowski / eslint-watch

ESLint with simple watching capabilities
https://www.npmjs.com/package/eslint-watch
MIT License
196 stars 29 forks source link

Full lint #103

Closed rizowski closed 7 years ago

rizowski commented 7 years ago

What was the problem/Ticket Number

This Implements #29

How does this solve the problem?

This adds a new flag called --changed. This enables current functionality of being able to lint a single file after every save. Default behavior is being changed to linting all files unless otherwise specified.

nmschulte commented 7 years ago

Does this incorporate a caching/optimization mechanism, so that only the changed files are re-linted, but the output includes all linting?

A breaking change that potentially makes the process take much much longer may anger users; the mechanism described would mitigate that.

rizowski commented 7 years ago

@nmschulte There isn't any caching built into eslint-watch. I know Eslint has a caching option that I can pass into the CliEngine. ESW should be passing any variables along but I haven't tested them fully so I will double check to make sure they are working properly.

rizowski commented 7 years ago

@nmschulte It is passing the cache variables correctly to CliEngine. I am going to merge this pull request now.