Closed imsodin closed 3 years ago
@ppknap ^
@imsodin thanks for submitting this issue! I don't have access to that particular Windows version and it seems it's not easily reproducible anyway. However, it could be the case that we receive incomplete status when the machine is being woken up.
I created a #192 that does two things:
notify
from panicking when this issue occurs again,Note, that when the Overlapped
structure does not include our extended(grip
) object, we won't be able to retrieve any events. Thus, the check I added will not result in filesystem notifications loss.
Thanks a lot for the speedy resolution. I guessed that it will be hard to reproduce/get to the bottom, but hoped you'd see what might cause it anyway and/or a general mitigation - and you did, awesome :)
From https://github.com/syncthing/syncthing/issues/7063:
Unfortunately it sounds like it isn't clear when/how it happens. However maybe the trace already points at what might be the culprit. I'll report back if any more details come up.