search

rjeczalik / notify

File system event notification library on steroids.
MIT License
900 stars 128 forks source link

dispatch queue #215

Closed josharian closed 1 year ago

josharian commented 1 year ago

~This is built atop #214, which isn't in yet; i will rebase once that goes in.~

I've asked a friend to help review this, to make sure I haven't screwed up anything obvious. Tests pass locally, with and without the race detector, but that doesn't necessarily mean it is correct. :)

kevboh commented 1 year ago

@josharian with the caveat that I'm not familiar with FSEventStreamSetDispatchQueue beyond reading through the docs, this looks correct to me.

josharian commented 1 year ago

OK, @rjeczalik, all yours for review, at your leisure. :)

rjeczalik commented 1 year ago

@josharian Sorry for letting it hang, holiday period and having less spare time than usual, I will get back to this some time around next week scout's word 🤞

josharian commented 1 year ago

Ping.

rjeczalik commented 1 year ago

@josharian Thanks! ❤️