Fixed WCO not responding to touch events on windows. #35177 (Also in 19, 20)
Fixed webContents.getUserAgent() incorrectly returning an empty string unless previously set. #35130 (Also in 17, 19, 20)
Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released. #35082 (Also in 19, 20)
Fixed context menu not showing all items on macOS when dock is not hidden. #35198 (Also in 19)
Fixed page size always being restricted to 4k on Linux arm64. #35184
Security: backported fix for CVE-2022-2478. #35099
Security: backported fix for chromium:1334864. #35097
electron v18.3.6
Release Notes for v18.3.6
Fixes
Fixed a crash when calling BrowserWindow.setEnabled(). #34973 (Also in 19, 20)
Fixed a potential crash when changing window settings after initializing WCO with an invalid titleBarStyle. #34873 (Also in 17, 19, 20)
Fixed alwaysOnTop BrowserWindow option for X11 Linux. #34911 (Also in 19, 20)
Fixed an issue where BrowserWindows on macOS were incorrectly marked as resizable. #34907 (Also in 19, 20)
Fixed an issue where Windows Control Overlay buttons did not respect maximizable/minimizable/closable states of a BrowserWindow. #34720 (Also in 17, 19, 20)
Fixed an issue where calling BrowserWindow.setRepresentedFilename on macOS with titlebarStyle: 'hiddenInset' or titlebarStyle: 'hidden' inadvertently moves the traffic light location. #34847 (Also in 19, 20)
Fixed an issue where some BrowserWindows opened from new links wouldn't properly load URLs. #34910 (Also in 19)
Fixed an issue where the minimize button with WCO enabled would incorrectly be highlighted in some cases. #34838 (Also in 17, 19, 20)
Fixed an issue with background colors being improperly applied to BrowserViews on Windows. #33478 (Also in 16)
Fixed empty app_id when running under wayland. #34877 (Also in 19, 20)
Fixed missing Sec-CH-UA headers and empty navigator.userAgentData. #34758 (Also in 17, 19, 20)
Fixed symbol generation on 32-bit Windows release builds. #35096 (Also in 19, 20)
Prevent brief display of "Ozone X11" in window title on Linux. #34943
Breaking changes will be documented here, and deprecation warnings added to JS code where possible, at least one major version before the change is made.
Types of Breaking Changes
This document uses the following convention to categorize breaking changes:
API Changed: An API was changed in such a way that code that has not been updated is guaranteed to throw an exception.
Behavior Changed: The behavior of Electron has changed, but not in such a way that an exception will necessarily be thrown.
Default Changed: Code depending on the old default may break, not necessarily throwing an exception. The old behavior can be restored by explicitly specifying the value.
Deprecated: An API was marked as deprecated. The API will continue to function, but will emit a deprecation warning, and will be removed in a future release.
Removed: An API or feature was removed, and is no longer supported by Electron.
Planned Breaking API Changes (23.0)
Removed: BrowserWindow scroll-touch-* events
The deprecated scroll-touch-begin, scroll-touch-end and scroll-touch-edge
events on BrowserWindow have been removed. Instead, use the newly available
input-event event on WebContents.
// Removed in Electron 23.0
win.on('scroll-touch-begin', scrollTouchBegin)
win.on('scroll-touch-edge', scrollTouchEdge)
win.on('scroll-touch-end', scrollTouchEnd)
// Replace with
win.webContents.on('input-event', (_, event) => {
if (event.type === 'gestureScrollBegin') {
scrollTouchBegin()
} else if (event.type === 'gestureScrollUpdate') {
scrollTouchEdge()
} else if (event.type === 'gestureScrollEnd') {
scrollTouchEnd()
}
})
The webContents.incrementCapturerCount(stayHidden, stayAwake) function has been removed.
It is now automatically handled by webContents.capturePage when a page capture completes.
const w = new BrowserWindow({ show: false })
// Removed in Electron 23
w.webContents.incrementCapturerCount()
</tr></table>
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/rk23597/udemy-downloader-gui/network/alerts).
Bumps electron from 4.1.3 to 18.3.7.
Release notes
Sourced from electron's releases.
... (truncated)
Changelog
Sourced from electron's changelog.
... (truncated)
Commits
dee6e01Bump v18.3.7483e39cchore: cherry-pick 97193a64b431 from chromium (#35184)cd7490dfix: consider dock space when showing menu (#35198)b990bd6fix: allow setsize to be called within a move or resize for preventDefault (#...56a0b45fix: modify file extension generation on Windows (#35171)5871f81fix: touch events not recognized by WCO on windows (#35117) (#35177)511f275ci: turn off windows on arm test result comments (#35167)8189ee6chore: add electron deps to //src gitignore (#35148)cc52f07ci: switch to GHA for WOA (#35127)890adefdocs: new main -> renderers messageChannel example (#35133)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/rk23597/udemy-downloader-gui/network/alerts).