rkpatrick / bizhawk

Automatically exported from code.google.com/p/bizhawk
1 stars 0 forks source link

Re-record count increments by 1 every time a movie is loaded #303

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open any movie file (Movie -> Play Movie...)
2. Select Movie -> Movie End
3. Open the Play Movie dialog again (last opened movie file should be selected 
automatically)

OR

1. Open any movie file (Movie -> Play Movie...)
2. Close BizHawk, then open it again
3. Select the last ROM you've opened
4. Open the Play Movie dialog again and select the last movie you've played 
back (no need to play back)

OR

1. Record a movie
2. End the recording after a few seconds without using savestates
3. Open the Play Movie dialog and select the movie you recorded (no need to 
play back)

What is the expected output? What do you see instead?
The re-record count shouldn't increment by one when you open the dialog (the 
re-record count should be 0 when you perform the third way of reproducing). 
Instead, it does whenever you do the above steps (i.e. the re-record count will 
be 1 when you perform the third way of reproducing).

What version of the product are you using? On what operating system?
BizHawk 1.8.4 on Windows 7 Home Premium x64

Please provide any additional information below.
It doesn't seem to matter if you edited the BK2 outside of BizHawk. It also 
doesn't matter when the movie is played back in read-only mode or not. I guess 
the best method of reproducing this bug is emptying the Movies folder (make a 
backup first if you have any movies!), then make a test recording and use that.

Original issue reported on code.google.com by fsvgm...@gmail.com on 1 Nov 2014 at 6:54

GoogleCodeExporter commented 9 years ago
The same happens on a fresh install of BizHawk 1.8.4.

Original comment by fsvgm...@gmail.com on 5 Nov 2014 at 4:33

GoogleCodeExporter commented 9 years ago
OK, so after some testing, it seems the issue started happening somewhere 
between versions 1.7.1 and 1.7.2.

Original comment by fsvgm...@gmail.com on 6 Nov 2014 at 5:29

GoogleCodeExporter commented 9 years ago
Fixed, revision 8173

Original comment by adeli...@tasvideos.org on 14 Nov 2014 at 12:14