search

rl-institut / SimBA

GNU Affero General Public License v3.0
2 stars 1 forks source link

Feature/output individual gc cost #156

Closed PaulScheerRLI closed 8 months ago

PaulScheerRLI commented 10 months ago

The cost calculation has been refactored and the functionality to calculate the individual grid_costs has been added. Garage costs are not included in the individual gc costs, but into the cumulated costs. A minor bug has been fixed where the call for SpiceEV cost calculation did not pass the proper station, which led to the same strategy argument each call, i.e. only a single type of station (deps or opps) and the associated strategy with this type was used to determine the electricity cost

PaulScheerRLI commented 9 months ago

Please structure the code in logical blocks, with separate headlines. Consider having the functions in the same order as they are called in calculate_costs. Maybe even pull that function to the top to serve as a kind of table of contents.

Calculate costs is now at the top. Methods are ordered by getters and setters.

PaulScheerRLI commented 8 months ago

A try/except block was added to both cost calculation and writing the cost to a file. This way, failed cost calculations do not break the whole report. In these cases, warning is logged.