search

rluders / wn-jwtauth-plugin

JWTAuth Plugin for WinterCMS
GNU General Public License v3.0
29 stars 28 forks source link

Install error "Method subMinutes does not exist." #53

Closed mlieshout closed 3 years ago

mlieshout commented 3 years ago

Hi,

I'm trying to install the plugin from the October CMS Marketplace and get this error:

"Method subMinutes does not exist." on line 96 of .../vendor/laravel/framework/src/Illuminate/Support/Traits/Macroable.php

rluders commented 3 years ago

Hello, @mlieshout.

Thank you for reporting the issue. Sorry about it. Let me run some tests, and validate the issue.

rluders commented 3 years ago

It seems that when I updated the plugin dependencies it overwrites some related dependencies, which is causing some conflicts with the ones that belong to OctoberCMS.

I'm planning to patch this issue this weekend. I let you know about it ASAP. Sorry about it.

It only reinforces what I was thinking a few weeks ago, that I need to spend some time adding some automated tests to the plugin.

mlieshout commented 3 years ago

Hi Ricardo,

Thanks for the update on this issue! I don't need it asap so please take your time to do what you have to do.

rluders commented 3 years ago

@mlieshout I just did a small fix. Can you try it and let me know? Thank you.

mlieshout commented 3 years ago

This is what I did:

Added the composer.json to the plugin directory and ran "composer update" Now I get this error:

"Method addSeconds does not exist." in vendor/laravel/framework/src/Illuminate/Support/Traits/Macroable.php line 96

Op vr 22 jan. 2021 om 14:53 schreef Ricardo Lüders <notifications@github.com

:

@mlieshout https://github.com/mlieshout I just did a small fix. Can you try it and let me know? Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rluders/oc-jwtauth-plugin/issues/53#issuecomment-765412767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSWB2DIPPNOQZIUKU4IPLS3F7ONANCNFSM4WGA4KPQ .

rluders commented 3 years ago

Ok. Thank you.

I don't know what is happening, I did the fix, it was working, then tried to install it again, and it seems that it is still broken.

I'll spend more time during the weekend. Doesn't seems to be something that simple to fix.

rluders commented 3 years ago

Just release the patch. It is working on 470, that is/or should be the same as the 471 release note

If you still having issues with 471, I do recommend you check the try to get "back" to 470 by reinstalling the OctoberCMS. I'm installing it using the composer (guide here) and it is working like a charm.

Also, I do recommend you reinstall the JWTAuth Plugin, just to make sure that everything is clean and shiny. :sun_with_face:

Please, let me know if you have any other issues.

rluders commented 3 years ago

I reported it to the OctoberCMS team, it seems to be an issue related to Marketplace itself. I'll keep following its progress.

rluders commented 3 years ago

All right. This is pretty similar to the issue that is also happening with my CORS plugin. So, you can find some better explanation here, but long story, short.

OctoberCMS has now 2 possible Laravel versions: 5.5 and 6. That is causing issues. I do recommend you to check your OctoberCMS Laravel version, instructions can be found here.

If you are not using the Laravel 6 version, you can update it, and the last version of both plugins should work. But I'll double test it during this weekend, and if necessary I'll release a reviewed release.

If you prefer to keep using the L5.5 version, would be better if you could get an older plugin version, from the release page. I think that v1.2.3 should work fine.

I'll not support both Laravel versions, and unfortunately, by the OctoberCMS marketplace, you cannot choose the version that you want to install, as well it doesn't install the version compatible with your Laravel version. Sorry about it.

And that is it. I'll mark this issue as wontfix and keep it open till the final OctoberCMS release to L6 which should happen soon.