search

rluders / wn-jwtauth-plugin

JWTAuth Plugin for WinterCMS
GNU General Public License v3.0
29 stars 28 forks source link

Support to Winter CMS 1.2 with Laravel 9 #67

Closed rluders closed 1 year ago

rluders commented 2 years ago

Now that Winter CMS 1.2 now supports Laravel 9, and tymon/jwt-auth seems to be totally abandoned, we need to replace it with php-open-source-saver/jwt-auth that is a fork from the tymon's librabry but with support to Laravel 9.

If you are using Winter CMS 1.2 and having issues with the plugin let me know on this issue, 'cause this could be the main reason.

josephcrowell commented 2 years ago

Yes I tried to do an upgrade to 1.2 and everything broke down. I was even getting internal server errors loading the backend. This is probably a major reason why, although I probably need to do upgrades in some of my plugins as well.

math-u commented 1 year ago

Hi! Any progress with the plugin to support Laravel 9? I am trying to use it with new October but having errors.

bkrajendra commented 1 year ago

getting error Declaration of RLuders\JWTAuth\Exceptions\JsonValidationException::getStatusCode()

bkrajendra commented 1 year ago

Any update on this?

rluders commented 1 year ago

I've been away from Laravel + Winter CMS for a while... PR to fix this issue is more than welcome.

bkrajendra commented 1 year ago

@rluders I managed to fix the above issue but am now stuck in endless CORS issues. Mostly I resolve it... but this time does not understand what the issue can be. I have exact same plugin code deployed in another server with WinterCms, but I am not able to go ahead due to the CORS issue. the only difference is working server has PHP 7.4 and this new one has 8+

rluders commented 1 year ago

@bkrajendra are you also using the https://github.com/rluders/wn-cors-plugin?

bkrajendra commented 1 year ago

No, i am not using this. I earlier tried this but does not help. I use angular as frontend, I also need error responses to have proper cors, so I prefer adding manually adding to those conditions, I know this is not a proper way to do it. I'll again try this plugin, as I have not tried it with wintercms.

bkrajendra commented 1 year ago

Hi @rluders , With the use of wn-cors-plugin, all working fine now. I have submitted the PR for the changes I made to migrate the plugin to php-open-source-saver/jwt-auth. Please review and merge it.

bkrajendra commented 1 year ago

@rluders can you please review and merge the PR.?

rluders commented 1 year ago

@bkrajendra yep, I will, just need to wait a little bit, I just returned from my vacation. But, I'll review it ASAP, not sure if today or during the week.

rluders commented 1 year ago

@bkrajendra PR merged. It should be good now. If someone found any issue, please let me know by opening another issue.