Supports ever changing lang folder

rmariuzzo / Laravel-JS-Localization

🌐 Convert your Laravel messages and consume them in the front-end!

https://github.com/rmariuzzo/laravel-js-localization

MIT License

596 stars 170 forks source link

Supports ever changing lang folder #170

Closed wilpat closed 2 years ago

wilpat commented 2 years ago

From laravel 4 to 8.x we've seen changes to where the lang folder lives and this breaks the functionality of this package.

This PR makes this path customisable, so the package does not need to be updated every time laravel makes an update to the location of this folder.

rmariuzzo commented 2 years ago

@wilpat released: https://github.com/rmariuzzo/Laravel-JS-Localization/releases/tag/v1.9.1

Chomiciak commented 2 years ago

Guys please... Not the Fix Friday again! @wilpat @rmariuzzo

My advice is to enable at least double review, if anyone (e.g. our projects) has the dependency set to ^1.9 you just broke all the CI/CD. Also don't do updates on Fridays so people don't have to work weekends to resolve possible issues 😭

Please flag the version as non-working as soon as possible.

rmariuzzo commented 2 years ago

@Chomiciak I apologize for this, that's on me. I removed the broken version from Packagist, I think that should alleviate that issue. Please, let me know if not.

rmariuzzo commented 2 years ago

Also, I appreciate your advice, I will make a call for more maintainers to make double review as you suggested.