search

rmariuzzo / react-new-window

🔲 Pop new windows in React, using `window.open`.
https://rmariuzzo.github.io/react-new-window/
MIT License
448 stars 110 forks source link

Include children in NewWindow type definition #129

Closed joy-void-joy closed 2 years ago

joy-void-joy commented 2 years ago

Fixes https://github.com/rmariuzzo/react-new-window/issues/118

This PR simply adds children?: React.ReactNode to NewWindow's type definition, which seems to be enough.

DarryQueen commented 2 years ago

Can we get a release for the typings?

JorgeMartinezVidaip commented 2 years ago

It would be nice to have

rmariuzzo commented 2 years ago

Will deploy a new version soon today.