search

rmariuzzo / react-new-window

🔲 Pop new windows in React, using `window.open`.
https://rmariuzzo.github.io/react-new-window/
MIT License
448 stars 110 forks source link

TypeError when trying to open 2 NewWindows in same window #159

Open Aleafan opened 8 months ago

Aleafan commented 8 months ago

Hi! Thanks a lot for your work!

I found that when trying to open 2 different NewWindow components in the window with the same name, TypeError in thrown: image

The problem is in the code below - staticContainer is not found so equals to null and removeChild method expects argument of type Node only.

// Remove any existing content
const staticContainer = this.window.document.getElementById(
  'new-window-container-static'
)
this.window.document.body.removeChild(staticContainer)

When I add staticContainer check it works just fine: staticContainer && this.window.document.body.removeChild(staticContainer)

Is it even supposed to work in that way?