search

rmbolger / Posh-ACME

PowerShell module and ACME client to create certificates from Let's Encrypt (or other ACME CA)
https://poshac.me/docs/latest/
MIT License
778 stars 190 forks source link

DNSPod Argument Names #552

Closed webprofusion-chrisc closed 5 months ago

webprofusion-chrisc commented 5 months ago

While reviewing https://github.com/webprofusion/certify/issues/677 I'm wondering what the correct arguments are for DNSPod, I had them mapped as DNSPodKeyID and DNSPodToken but it looks like the script is expecting DNSPodKeyId and DNSPodKeyToken (not sure if case matters, but I can see how DNSPodToken would work).

Weirdly some users seem to be managing to use it ok in Certify (?), and some don't but that could just be a side-effect of something else.

rmbolger commented 5 months ago

As far as I can tell, the correct arguments have always been DNSPodKeyID and either DNSPodKeyToken or DNSPodKeyTokenInsecure. Case shouldn't matter. However, the plugin guide is wrong in the example code. So thanks for noticing!

PowerShell does allow you to shorten parameter names as long as the shortened version is still unique among the rest. But I don't see how DNSPodToken would have ever worked because it's not a shortened version of anything.

rmbolger commented 5 months ago

Doc fix is live.

webprofusion-chrisc commented 5 months ago

Thanks!