rmcgibbo / slidedeck

Beautiful HTML5 slides in markdown. A easy-to-use fork of the google-io-2012 slide deck
317 stars 47 forks source link

Special characters in title #17

Open kyleabeauchamp opened 10 years ago

kyleabeauchamp commented 10 years ago

I've found two different issues.

With title "(How) Are Protein Forcefields Getting Better?" I end up with slidedeck render hanging.

With title "Are Protein Forcefields Getting Better?" I end up with an extra slide after the title showing only a single "?" character.

rmcgibbo commented 10 years ago

Unicode issues maybe? I'm in Thailand on vacation, so I'm afraid I won't be of much use.

Sent from my iPhone

On Dec 9, 2013, at 5:48 AM, kyleabeauchamp notifications@github.com wrote:

I've found two different issues.

With title "(How) Are Protein Forcefields Getting Better?" I end up with slidedeck render hanging.

With title "Are Protein Forcefields Getting Better?" I end up with an extra slide after the title showing only a single "?" character.

— Reply to this email directly or view it on GitHub.

kyleabeauchamp commented 10 years ago

No worries, I have a workaround where I manually create title slide in base.html.

rmcgibbo commented 10 years ago

If you can find and fix the issue in a generic way, I'm still happy to merge commits.

Sent from my iPhone

On Dec 10, 2013, at 8:15 AM, kyleabeauchamp notifications@github.com wrote:

No worries, I have a workaround where I manually create title slide in base.html.

— Reply to this email directly or view it on GitHub.

tjd commented 10 years ago

I can't put "C++" in the title. It seems that ++ is being mis-handled by the regular expression matching in parse_deck_settings and so somehow needs to be escaped.