rmcgibbo / slidedeck

Beautiful HTML5 slides in markdown. A easy-to-use fork of the google-io-2012 slide deck
317 stars 47 forks source link

TypeError: document.body is null #2

Closed kyleabeauchamp closed 11 years ago

kyleabeauchamp commented 11 years ago

The slides don't seem to work for me. I created a project, rendered, and used firefox index.html.

Firefox seems to find an error at line 664 of slide-deck.js, so I wonder if that's it.

kyleabeauchamp commented 11 years ago

Ubuntu 12.04, firefox 21.

rmcgibbo commented 11 years ago

Does the example project work in your browser? If so, I can try to see if the newest slidedeck code is generating something different on that markdown.

https://github.com/rmcgibbo/slidedeck-example

-Robert

On May 27, 2013, at 3:27 PM, kyleabeauchamp wrote:

The slides don't seem to work for me. I created a project, rendered, and used firefox index.html.

Firefox seems to find an error at line 664 of slide-deck.js, so I wonder if that's it.

— Reply to this email directly or view it on GitHub.

kyleabeauchamp commented 11 years ago

Same issue--black browser window, typeerror in inspector.

rmcgibbo commented 11 years ago

Okay, I can confirm it now. This page seemed to be working in firefox (but not chrome) http://htmlpreview.github.io/?https://github.com/rmcgibbo/slidedeck-example/blob/master/index.html, but when I serve it from localhost by just navigating to the file, it doesn't seem to work.

I think there's a timing issue with some of the code executing before the DOM is fully loaded. I'll take a look. Thanks for pointing it out.

-Robert

On May 27, 2013, at 3:54 PM, kyleabeauchamp wrote:

Same issue--black browser window, typeerror in inspector.

— Reply to this email directly or view it on GitHub.

rmcgibbo commented 11 years ago

Nevermind. from localhost, slide-deck example is working in chrome and safari, but failing (typeerror, line 664 as you said) in firefox.

rmcgibbo commented 11 years ago

Okay, I committed a fix (I think) to slidedeck-example. Can you pull that and see if it works for you too? If so, I'll commit the same change to this repository.

kyleabeauchamp commented 11 years ago

fixed

rmcgibbo commented 11 years ago

Okay. I pushed that commit up. I think it's fixed. If you confirm, I'll close the issue.

kyleabeauchamp commented 11 years ago

Fixed

rmcgibbo commented 11 years ago

Sweet