search

rmjarvis / TreeCorr

Code for efficiently computing 2-point and 3-point correlation functions. For documentation, go to
http://rmjarvis.github.io/TreeCorr/
Other
97 stars 37 forks source link

is bin_slop in log or linear space when using log binning? #163

Closed beckermr closed 7 months ago

beckermr commented 7 months ago

As in the title.

rmjarvis commented 7 months ago

cf. https://rmjarvis.github.io/TreeCorr/_build/html/binning.html#bin-slop

The units of bin_slop is bins.

beckermr commented 7 months ago

I read the docs and am still confused. I see

The approximation TreeCorr makes is to allow some additional imprecision that is a fraction of this level. Namely bin_slop. Specifically, bin_slop specifies the maximum possible error any pair can have, given as a fraction of the bin size.

For log binning, is the bin size log(10) - log(20) or 10-20?

rmjarvis commented 7 months ago

The log values are what are relevant if doing log binning.

In the interest of extreme precision, here is the code that does the calculation: https://github.com/rmjarvis/TreeCorr/blob/releases/4.3/include/BinType.h#L111