search

rmosolgo / graphiql-rails

Mount the GraphiQL query editor in a Rails app
MIT License
447 stars 135 forks source link

Remove `Gem::Specification#test_files=` to reduce gem package size #88

Closed pocke closed 3 years ago

pocke commented 3 years ago

Gem::Specification#test_files= is no longer recommended. https://github.com/rubygems/guides/issues/90

And it increases gem package size because the option adds test files to the package.

So I think we should avoid using test_files= option.

It reduces 4.7MB package size on my local.

before

$ du graphiql-rails-1.7.0/ --summarize
6.7M    graphiql-rails-1.7.0/

after

$ du graphiql-rails-1.7.0/ --summarize
2.0M    graphiql-rails-1.7.0/
rmosolgo commented 3 years ago

Thanks!