search

rmosolgo / graphql-ruby

Ruby implementation of GraphQL
http://graphql-ruby.org
MIT License
5.38k stars 1.39k forks source link

Getting FiberError after deploying with 2.4.4 #5168

Closed aub closed 1 day ago

aub commented 1 day ago

Describe the bug

We recently deployed with 2.4.4 and started getting errors like this:

Screenshot 2024-11-21 at 12 28 41 PM

Rolling back to 2.4.3 appears to have resolved the issue.

Versions

graphql version: 2.4.4 rails (or other framework): Rails 7.2.2 other applicable versions (graphql-batch, etc)

aub commented 1 day ago

Sorry, this was unrelated to graphql-ruby.

rmosolgo commented 1 day ago

Hi! I'm glad you got to the bottom of it. If you're able to share anything about how you addressed this problem, I'd love to hear it. It might help someone else who encounters this error, too!

aub commented 13 hours ago

Sure thing. We suspected graphql-ruby due to the call stack and because we had just recently upgraded the version to 2.4.4. It turned out we had a GraphQL::Dataloader::Source that was effectively loading in an infinite number of objects because we weren't using a connection when we clearly should have. This was exhausting memory, causing a crash that appeared to be in the graphql-ruby dataloader code.