search

rncbc / drumkv1

drumkv1 - an old-school drum-kit sampler
https://drumkv1.sourceforge.io
GNU General Public License v2.0
35 stars 6 forks source link

Fix crash when dragging on virtual keyboard beyond left edge #30

Closed audiofranky closed 4 years ago

audiofranky commented 4 years ago

When clicking&dragging with the mouse on the virtual keyboard, a crash will happen if you move the mouse quickly to the left beyond the keyboard (this creates negative values for "note"), causing a lookup error in drumkv1_ui::noteName().

By the way, this my first GitHub pull request ever, so let me know if I screwed up somehow :-).

rncbc commented 4 years ago

fixed upstream in https://github.com/rncbc/drumkv1/commit/b0cbb34

thanks && hny!