search

rncbc / samplv1

samplv1 - an old-school polyphonic sampler
https://samplv1.sourceforge.io
GNU General Public License v2.0
38 stars 8 forks source link

Make the UI work without instance-access #34

Open falkTX opened 3 years ago

falkTX commented 3 years ago

Hello again :)

This is a feature request, for which we at MOD Devices are willing to submit a PR to. We have been looking into samplv1 and the steps to make it all work without instance-access are within small reach: 1 - properly save and restore lv2 parameter data as part of the plugin state, see #33 2 - notify the UI when these parameters are changed by the host (as part of state restore) 3 - when loading a sample, make an atom float-vector of its peaks to send to UI

That should do it. It is already quite close since you are using the lv2 parameter APIs for file management.

I don't expect you to do any work here, just wanted to start the conversation about this. We (at MOD) will be pushing a PR soon that achieves this, just wanted to mention this, as perhaps you have any important things to note or even objections. Thanks

rncbc commented 3 years ago

eagerly awaiting the PR... I must say I'll be surprised if it doesn't break it all loose into a mess and/or a very different code-base ... just to please MOD Devices? ;) your call anyway... maybe a new branch, perhaps?

falkTX commented 3 years ago

nah, we want to keep this as close as possible to upstream. the build system is the odd one, because we need to build without GUI support.

since it was me confused on issue 1 above, the actual work to do is considerably quite small then. for a first iteration, we just need to notify the UI when a state restore happened, so it re-sends all "internal" parameter values.