search

rnd-ash / ecu_diagnostics

A Rust crate for ECU diagnostic protocols (UDS / KWP)
GNU General Public License v3.0
170 stars 28 forks source link

UDSCommand missing services #14

Closed camercu closed 1 year ago

camercu commented 2 years ago

Going based off Wikipedia (again, sorry I don't have access to the official standard), it appears the UDSCommand enum is missing SID 0x29 (Authentication) and 0x38 (Request File Transfer). If you have access to the standard, can you please check it to see if these are actually missing standard services?

camercu commented 2 years ago

This blog post suggests that the Service IDs I mentioned are part of the newest (2020) revision to the UDS standard.

nyurik commented 1 year ago

@camercu I fixed this as part of the v0.4.1 of the auto_uds crate. ECU diagnostics now uses it too.

nyurik commented 1 year ago

I think this can now be closed

rnd-ash commented 1 year ago

Agreed!