search

rnpm / rnpm-plugin-upgrade

rnpm upgrade
Other
18 stars 1 forks source link

Incorrectly added `-lc++` flag to `Tests` scheme #2

Open jhen0409 opened 8 years ago

jhen0409 commented 8 years ago

I'm using this plugin to upgrade xcodeproj file, but it seems will add -lc++ flag to Tests scheme.

Use rnpm upgrade, it will add lc++ to Tests scheme. Use react-native upgrade, It will add lc++ to right place.

Kureev commented 8 years ago

cc @grabbou

grabbou commented 8 years ago

Yeah, good catch! In fact we have discarded rnpm upgrade in the meantime as it turns out the react-native upgrade does all these things for us!

I don't think this is harmful side-effect, esp. that you have to add it anyway when using SnapshotTests or other React-related code in that target.

Sorry for the inconvenience!