roadrunner-server / roadrunner-plugins

📦 Home for the roadrunner plugins
MIT License
25 stars 9 forks source link

fix(static, http): set headers right before the serve #125

Closed rustatian closed 2 years ago

rustatian commented 2 years ago

Reason for This PR

closes: #115

Description of Changes

No static headers in the regular request image

  static:
    dir: "../../../tests"
    forbid: [ "" ]
    allow: [ ".txt", ".php" ]
    calculate_etag: true
    weak: false
    request:
      input: "custom-header"
    response:
      output: "output-header"

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

codecov[bot] commented 2 years ago

Codecov Report

Merging #125 (9269d01) into master (69c14c8) will decrease coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head 9269d01 differs from pull request most recent head 8a84363. Consider uploading reports for the commit 8a84363 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   65.39%   65.34%   -0.05%     
==========================================
  Files         135      135              
  Lines       10822    10816       -6     
==========================================
- Hits         7077     7068       -9     
- Misses       3040     3042       +2     
- Partials      705      706       +1     
Impacted Files Coverage Δ
http/serve.go 71.22% <ø> (+0.18%) :arrow_up:
http/middleware/static/plugin.go 71.02% <100.00%> (ø)
beanstalk/beanstalkjobs/item.go 77.14% <0.00%> (-2.86%) :arrow_down:
boltdb/boltjobs/listener.go 61.32% <0.00%> (-2.84%) :arrow_down:
redis/pubsub/pubsub.go 72.86% <0.00%> (-2.33%) :arrow_down:
tcp/plugin.go 72.17% <0.00%> (+0.86%) :arrow_up:
sqs/sqsjobs/item.go 67.10% <0.00%> (+1.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69c14c8...8a84363. Read the comment docs.