rob-b / pytest-blockage

py.test plugin that can disable network requests during a test run.
MIT License
18 stars 12 forks source link

Move to pytest-dev team? #3

Open nicoddemus opened 9 years ago

nicoddemus commented 9 years ago

Please consider moving to new pytest-dev team. See contributing for more information.

Cheers,

rob-b commented 9 years ago

I don't think this plugin meets the requirements for inclusion currently (I also don't think it's a particularly useful plugin, I don't even use it myself) but I'll try and get it into shape and submit it soon. I'd just transfer ownership though as I don't want group membership

On 3 March 2015 at 00:11, Bruno Oliveira notifications@github.com wrote:

Please consider moving to new pytest-dev https://github.com/orgs/pytest-dev team. See contributing https://bitbucket.org/pytest-dev/pytest/src/e26175bf8246f01fc5573e92359b3124624c31b7/CONTRIBUTING.rst?at=default#rst-header-id8 for more information.

Cheers,

— Reply to this email directly or view it on GitHub https://github.com/rob-b/pytest-blockage/issues/3.

jayvdb commented 4 years ago

I've evaluated a lot of similar pytest and nose plugins, and this is one of the best for an isolated VM - it traps network activity before the name resolution and socket related exceptions occur. Most trap connection opening, which is wayyy too late. c.f. https://github.com/venmo/nose-detecthttp/issues/9 , https://github.com/miketheman/pytest-socket/issues/25 & https://github.com/kevin1024/vcrpy/issues/425

One I havent tried is https://github.com/disqus/nose-socket-whitelist , as I rarely encounter nose projects which use network and do not already have support for disabling network tests.