search

robdecker / labeled_telephone

Drupal 8 telephone field, with a label
0 stars 0 forks source link

Drupal 9 and PHP 8 compatibility #1

Open seanr opened 2 years ago

seanr commented 2 years ago

This is the initial pass, just getting it to enable in Drupal 9; more to come if I find other issues:

diff --git a/labeled_telephone.info.yml b/labeled_telephone.info.yml
index f0094ee..b56272b 100644
--- a/labeled_telephone.info.yml
+++ b/labeled_telephone.info.yml
@@ -3,8 +3,8 @@ type: module
 description: 'Defines a field type for telephone numbers, with a label.'
 package: Field types
 version: 1.0
-core: 8.x
+core_version_requirement: ^8 || ^9

 dependencies:
   - field
-  - telephone
+  - telephone
\ No newline at end of file
seanr commented 2 years ago

Really don't know why github is so restrictive on filetypes, otherwise I would have uploaded the patch file itself. Given my workflow getting this into composer, a PR is less than ideal, but I'll create one once completed.