search

robert-strandh / SICL

A fresh implementation of Common Lisp
Other
1.07k stars 79 forks source link

Error in clasp while compiling esrap, seems to stem from sicl #124

Open kpoeck opened 5 years ago

kpoeck commented 5 years ago

In https://github.com/robert-strandh/SICL/blob/master/Code/Cleavir/Kildall/Specializations/Type-inference/insert-type-checks.lisp#L73:

shouldn't that be:

(destructuring-bind (&optional (car '*) (cdr '*)) (rest typespec) ...)

instead of

(destructuring-bind (&optional (car '*) (cdr '*)) typespec ...)

The later `(cons ,car-d ,cdr-d) seems to confirm that.

Original issue with context: https://github.com/clasp-developers/clasp/issues/644

kpoeck commented 5 years ago

I closed the clasp issue since as you said it belongs to sicl, so lets try again here