search

robertdebock / ansible-role-users

The purpose of this role is to add users and groups on your system.
https://robertdebock.nl/
Apache License 2.0
42 stars 27 forks source link

Make role work well with usernames containing a '.' (dot) sign. #24

Closed piotrekzurek closed 2 years ago

piotrekzurek commented 2 years ago

PR for #23

name: Pull request about: Making role work well with usernames containing a '.' (dot) sign. Currently it doesn't work for such users.

Describe the change It uses jinja filter to replace '.' signs to "dot" string in filename refering to username, so the sudo application won't ommit this file (which is by design of sudo (see sudoers(5) manual.

Testing In case a feature was added, how were tests performed? locally on rocky linux and debian. added a user into molecule converge.yaml config, pipeline testing

piotrekzurek commented 2 years ago

Dear maintainer(s), this PR should pass all the molecule tests now. Please consider approving running workflows again. I'm sorry for previously pre-mature PR to this repository - i'm yet learning github ways of doing things. I've enabled actions on my cloned repo and the tests were obviously not clean. They seem to pass cleanly now.

robertdebock commented 2 years ago

CI running, no worries, just try as often as you need to. You can test locally if you'd like to try stuff, but once again, just try, I'm not bothered by these attempts.