search

robertdfrench / git-pr

Pull requests without Git(Hub|Lab)
GNU General Public License v3.0
0 stars 1 forks source link

GitHub Actions checks out repo for PRs in detached head #17

Closed calebwherry closed 3 years ago

calebwherry commented 3 years ago

GitHub decided that when it runs Actions, it checks out PRs in detached head. See info here: https://github.com/actions/checkout/issues/6

This is a problem for us because we need a working git and repo to run integration tests.

calebwherry commented 3 years ago

None of the workarounds actually work for us. The current output of "git all branches" is:

"* pull-request\n remotes/pull/1/merge\n"

This is... not what we are expecting. Not sure how to resolve this one. @robertdfrench we'll have to dig into this a little more.

calebwherry commented 3 years ago

@robertdfrench I've been thinking about what to do here. I wonder if it would be better for our integration tests to have a setup step create a new repo. That way we don't rely on the current repo state for testing?

Hopefully this wouldn't add too much overheard to our test running time. Would also help with isolation as we could set it up exactly like we want.