Fix bug that can cause param/query labels to be dropped.

robertzk / microserver

Minimal R server

MIT License

7 stars 2 forks source link

Fix bug that can cause param/query labels to be dropped. #5

Closed michaelochurch closed 9 years ago

robertzk commented 9 years ago

Looks good, but verify my comment about has_names.

michaelochurch commented 9 years ago

It's pathological but it can happen.

    > bad <- c(1, 2, 3, 4)
    > names(bad) <- c("")
    > names(bad)
    [1] "" NA NA NA
    > is.null(names(bad))
    [1] FALSE
    > names(bad)[1] <- NA
    > names(bad)
    [1] NA NA NA NA
    > is.null(names(bad))
    [1] FALSE

On Wed, Feb 11, 2015 at 4:33 PM, Robert Krzyzanowski < notifications@github.com> wrote:

Looks good, but verify my comment about has_names.

— Reply to this email directly or view it on GitHub https://github.com/robertzk/microserver/pull/5#issuecomment-73979610.

robertzk commented 9 years ago

Nice example.

coveralls commented 9 years ago

Coverage increased (+2.71%) to 67.5% when pulling 8b221d1c004c26c2200377dc4c50f9d083697a5d on params-bugfix into b6137303a0cf50d9c79899b0e0bc71693341164c on master.