search

robinbowes / flac2mp3

flac2mp3 is a tool to convert audio files from flac to mp3 format including the copying of tags.
GNU General Public License v3.0
141 stars 29 forks source link

Feature/report finish time #24

Open carlasplund opened 11 years ago

carlasplund commented 11 years ago

estimate time remaining (step 5/5)

Present timing of each transcode to 0.1 s resolution and also, after 20 s of transcoding, display the estimated time remaining for the whole job. The latter time is extapolated from the total file size converted so far and from the time elapsed since transcoding begun.

The estimed time remaining is updated each time a file is transcoded. The accuracy of the estimation will successively improve during the job as more and more files are transcoded.

This is the fifth and final changeset for the step-by-step implementation of progress reporting.

fatso83 commented 9 years ago

For a small time I was thinking that this project was abondoned by looking at the date of this PR (2013) and the fact that there was no discussion around it. But then I saw the closed PRs, the latest as of last month!

What's preventing this (and the other PRs from Carl) from being merged? Other than the obvious merge conflict, of course, which I assume has arisen due to time gone by...

robinbowes commented 9 years ago

It's essentially down to lack of time on my part to take a look at this (and other PRs).

This one is particularly huge and I am unlikely to be inclined to work my way through it in its current form.

It certainly needs rebasing, and I'd prefer a series of much smaller commits.

R.

fatso83 commented 9 years ago

Thanks - totally OK with that.