Dropdown script

[GaryJones]

While the genwpacc-dropdown.js code looks considerably better now it's in a module, it still has some issues:

• The mouseleave delay() bit doesn't work at all, since that is only for animations. Without that bit working, it's pointless adding the class for mouseenter in the first place.
• The settings are mixed in with the functionality. Changing the hover class means editing in three places, and that opens up the chance of human error.
• The code has no unit tests.
• The code can't be pulled into a theme for concatenating and minifying for performance benefits.

I've created a new jQuery plugin: https://github.com/GaryJones/accessible-menu . It:

• Fixes the timeout and attempts to clear the timeouts when another menu item is hovered over.
• Has public options that can be set globally or at run-time
• Comes in minified or unminified versions.
• Has Bower support so it can be pulled in via Bower into a theme or plugin.
• Has unit tests.

If you want to update your script with the code from my plugin, go ahead.

In the grand scheme of things though, I'd like to see Genesis Accessible dropping the current script, and just enabling and configuring the Superfish script that Genesis already includes. That already enables keyboard support, delay mouseleave, but also touch events, support for hoverIntent and so on and will be far better tested in real-world scenarios than either your current script or my plugin.

[rianrietveld]

Using SuperFish is indeed a better solution, I agree, since it's already in Genesis. And If Genesis drops SuperFish support, we can always add it to the plugin. Will look into that.

Nice plugin, your accessible-menu, by the way :-)

[rianrietveld]

Closing this, SuperFish is a no go for G 2.2. And this file is only used for < Genesis 2.2. Above, it uses the one from Genesis core, that is exactly the same.