search

robocorp / rpaframework

Collection of open-source libraries and tools for Robotic Process Automation (RPA), designed to be used with both Robot Framework and Python
https://www.rpaframework.org/
Apache License 2.0
1.17k stars 227 forks source link

`RPA.Browser.Selenium` type hinting/conversions #95

Closed osrjv closed 1 year ago

osrjv commented 3 years ago

Some keywords in the RPA.Browser always expect to receive strings, which creates surprising errors. For instance Select From List By Value does not function as expected when given an integer.

The library should have type hints for automatic RF argument conversion and/or explicit casts where certain types are expected.

osrjv commented 3 years ago

Not sure if this issue is actually relevant anymore as the upstream selenium library has type hints these days, but keeping here for tracking purposes.

mikahanninen commented 1 year ago

Typing is common practice nowadays in library development so I will close this issue. We ofc don't have control on upstream packages, but for rpaframework this is the practice.