search

robolson / ruby-poker

Ruby library for comparing poker hands and determining the winner.
BSD 3-Clause "New" or "Revised" License
99 stars 42 forks source link

Namespace classes inside RubyPoker module #6

Closed bbuchalter closed 6 years ago

bbuchalter commented 10 years ago

Other Ruby libraries implement the Card class. By namespacing, we can avoid conflicts.

While this looks like a massive change, it's really just indenting all the lines. There may also be concerns about backwards compatibility with other code folks have written against this library, but I think this is a worthwhile change.

robolson commented 9 years ago

why did you choose to create the ClassReferences module in test/support instead of including the RubyPoker module into each test class (or even inside the test_helper)?

bbuchalter commented 9 years ago

@robolson I guess my thinking was that should the class names or namespaces have to change again, you'd only make one change in the tests? Perhaps an overzealous application of the DRY principle.