search

robot256 / cargo_ships

factorio mod that adds cargo ships and other content to the game
6 stars 10 forks source link

Update control.lua #18

Closed EgliHannes closed 1 year ago

EgliHannes commented 1 year ago

Typo on Line 71, broke placeability of the Oil Rig in deep water

tburrows13 commented 1 year ago

There may be a bug in the area, but that’s not a typo. # is a length-of operator, so it is checking if find_entities_filtered has returned anything.

tburrows13 commented 1 year ago

If you've got a bug report, please send a save and I'm happy to look at it :)

EgliHannes commented 1 year ago

Earth Cities 4.zip

My apologies, I just assumed it was a typo, I wasn't familiar with the operator and it worked without an issue after I deleted it. The Oil Rig already there was placed without the operator. Thank you for your time.

Is here okay or did you mean open e bug report somewhere else?

tburrows13 commented 1 year ago

Here’s fine, thanks

tburrows13 commented 1 year ago

Ah, those oil patches there are 'crude oil' not 'offshore oil'. They should have been converted into offshore oil when you explored the chunks, but that has evidently failed to happen. I'll have a look as to why that might be.

tburrows13 commented 1 year ago

Basically, the offshore oil placement system fundamentally doesn't work with the script-placed tiles of Cities Of Earth. It would take a lot of work to get them to work with each other, which I don't see happening, sorry.

tburrows13 commented 1 year ago

It looks like if you turn off the mod setting "No offshore oil in shallow water" and then run /regenerate-oil Earth, it does then correctly convert the oil into offshore oil.

EgliHannes commented 1 year ago

Yeah I suspectet something like that. Allthough, may be a stupid question, why don't you just allow the Oil Rig to be placed on any type of Oil as long as it's on water? Or as long it isn't on land? Wouldn't that kind of solve a lot of mod incompability?

robot256 commented 1 year ago

The offshore oil is richer than normal oil deposits, and the script combines them together so that they aren't too close together to place rigs on each of them.

I'm going to close this PR now.