search

robotframework / OldSeleniumLibrary

Deprecated Selenium library for Robot Framework
Apache License 2.0
13 stars 3 forks source link

functions in _element.py should check before prefixing "xpath=" to passed in xpath arguments #247

Closed spooning closed 9 years ago

spooning commented 9 years ago

Originally submitted to Google Code by mohanraj... on 2 Aug 2012

VERSION = '1.0.1'

There are two functions in keywords_element.py

get_matching_xpath_count() xpath_should_match_x_times()

that I guess exclusively take xpath when compared to other functions.

I guess it is ok for these functions to assume that only xpath will be passed in.

But they do a weird thing by prefixing "xpath=" to the passed in argument without checking if the argument already has "xpath=".

This results in error in cases like mine, where I am reusing locators that have been defined with "xpath=" and used elsewhere in the project with other Selenium2Library functions.

I guess doing the check before prefixing will be a minor thing to add. Let me know if it makes sense and I can do it.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 6 Aug 2012

This seems reasonable. If you provide a patch, I can incorporate it.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 27 Aug 2012

After looking at the issue closer, it seems that you actually use selenium2library. IT has its own issue tracker, https://github.com/rtomac/robotframework-selenium2library. Please report this issue there, if it is still valid.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 27 Aug 2012

This is actually also problem in SeleniumLibrary and despite #2, I am going to fix this here also.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 27 Aug 2012

And, after reviewing the code, we do no such thing, so closing this as invalid,