robotics-in-concert / rocon_demos

Demo software for rocon milestones.
2 stars 14 forks source link

migrate vending machine to rocon_devices. #42

Closed jihoonl closed 10 years ago

stonier commented 10 years ago

I initially intended rocon_devices for standard/official devices. This will be a stack we officially release for public consumption so should only include drivers for devices that other people use (e.g. phillips hue) but not our custom experimental devices for demos.

bit-pirate commented 10 years ago

What about moving the vending machine there, but put it into a separate branch?

Btw, both the vending machine and automatic door are controlled by an Arduino (Yun). At some point it might be could to have a more generic interface for it. This would then be a good candidate for a release. But I'm still waiting for a good reason for putting in this extra work.

jihoonl commented 10 years ago

Both of you are right. Until @bit-pirate finds some time to implement generic arduino yun interface, let's have VM and auto door in separate demo branch since both are useful in more than one demo.

how about demo_devices ?

stonier commented 10 years ago

I'm guessing it is currently in rocon_demos. Is there a reason it doesn't fit there? Awkward dependencies?

bit-pirate commented 10 years ago

Auto door is already in rocon devices. Was under the impression that would be the right place (alongside rocon_hue.) So, will to migrate it.

On Mon, May 26, 2014 at 2:12 PM, Daniel Stonier notifications@github.comwrote:

I'm guessing it is currently in rocon_demos. Is there a reason it doesn't fit there?

— Reply to this email directly or view it on GitHubhttps://github.com/robotics-in-concert/rocon_demos/issues/42#issuecomment-44157807 .

Innovation Team Leader Yujin Robot Seoul, Republic of Korea Twitter: @yujinrobotinno Website: http://inno.yujinrobot.com Email: marcus.liebhardt@yujinrobot.com Phone: +82-70-46577073

jihoonl commented 10 years ago

I meant the branch...

jihoonl commented 10 years ago

To conclude,

All good?

bit-pirate commented 10 years ago

:+1:

stonier commented 10 years ago

:+1:

jihoonl commented 10 years ago

All done. Also note that vendming_machine_control messages are now in rocon_demo_msgs indigo-devel branch.