roboticslab-uc3m / teo-main

TEO full-sized humanoid robot: super/meta repository.
http://roboticslab.uc3m.es/roboticslab/robot/teo-humanoid
GNU Lesser General Public License v2.1
4 stars 1 forks source link

Review and Unify TEO link names #37

Open jgvictores opened 6 years ago

jgvictores commented 6 years ago

Review and Unify TEO link names, in parallel to https://github.com/roboticslab-uc3m/teo-main/issues/16 (dynamic info), etc.

jgvictores commented 6 years ago

Note: would like to change teo-simox-names.pdf -> teo-link-names.pdf or similar. Must update the following current items after that:

AlvaroMartinezR commented 6 years ago

@jgvictores I am not sure fi you want to change the names I used in simox to other or the other way around, change the simox ones.

jgvictores commented 6 years ago

Simox names are good! Unless there is some other naming for the links, I think it would be cool to adopt the ones you have on the PDF everywhere (thus could drop the simox from name, as becomes generic info).

AlvaroMartinezR commented 6 years ago

Ok, now I understand. I know that the ones used in openrave are something like r10.001.

jgvictores commented 6 years ago

Will probably be renaming and moving things around today, have presentation on TEO tomorrow evening! :-)

PeterBowman commented 5 years ago

Note: "saggital, frontal, axial..." might be misplaced, e.g. current saggital leg links are actually frontal links according to https://en.wikipedia.org/wiki/Anatomical_plane.

PeterBowman commented 4 years ago

Note: review and unify OpenRAVE link names, too.

jgvictores commented 4 years ago

Note: review and unify OpenRAVE joint names, too.

Updated issue description. May have added some overkill: for now our .ini's do not contain this sort of info.

jgvictores commented 4 years ago

ASWB, we'll name links as previous joints, in a DH fashion.

rsantos88 commented 4 years ago

In order to help with this issue, and to be sure that I've understood it, do you want to replace, for example q10 here by FrontalRightShoulder or by the label FRS15 following this table? Is it right?

jgvictores commented 4 years ago

Hi! The table is the correct one, and we'd use the first column, e.g. FrontalRightShoulder as you said.

However, q10 would be a joint, to be done at https://github.com/roboticslab-uc3m/teo-main/issues/44. <- We can start with this issue first! :smile:

This issue refers to links, with names such as r10. This can be slightly more tedious. Things to be taken into account:

jgvictores commented 4 years ago

Regarding the OpenRAVE model, since https://github.com/roboticslab-uc3m/teo-openrave-models/pull/35 has been merged, I guess this could be done (warning! pretty tedious ^^).

rsantos88 commented 4 years ago

Done at https://github.com/roboticslab-uc3m/teo-openrave-models/pull/36 according to https://github.com/roboticslab-uc3m/teo-developer-manual/blob/master/fig/teo-link-names.pdf