search

robotology / assistive-rehab

Assistive and Rehabilitative Robotics
https://robotology.github.io/assistive-rehab/doc/mkdocs/site
BSD 3-Clause "New" or "Revised" License
21 stars 11 forks source link

Use I/F to retrieve depth camera's parameters #298

Closed pattacini closed 3 years ago

pattacini commented 3 years ago

This PR addresses #297. Careful tests are required.

pattacini commented 3 years ago

I think we can survive this time w/o fixing Better Code Hub warnings 😏

pattacini commented 3 years ago

Disabled CI workflow that is continuously failing

pattacini commented 3 years ago

@vvasco maybe we could get back to this PR after the holidays?

vvasco commented 3 years ago

I tested these changes in gazebo and I realized that the RGBDSensorClient actually does not rely on local and remote, rather on other parameters. I updated the branch accordingly, tested it in gazebo and it worked. I will have to test these changes on the robot too.

pattacini commented 3 years ago

Hi @vvasco

I've just cleaned up some leftovers. I think we can merge this PR.

As the last comment, I realized that the following line of lineDetector might be streamlined with resort to I/F:

https://github.com/robotology/assistive-rehab/blob/90323e52ed4d24c990ef04f3160076d80642d13d/modules/lineDetector/src/main.cpp#L251

You may consider doing this straight in https://github.com/robotology/assistive-rehab/tree/fix/etapas instead.

The same does NOT apply to skeletonRetriever as there's yarpOpenpose as a man in the middle.

pattacini commented 3 years ago

Merged!

@vvasco you could now rebase fix/etapas on top of master.