Pull request #1 added the model of the iCub humanoid robot. The model was adapted from the icub-models repository. Before https://github.com/robotology/icub-model-generator/pull/129 (read discussion in https://github.com/robotology/gym-ignition/issues/130), when the URDF was converted to SDF, the fixed joints of the upstream model used for the robot's FT sensors were transformed to revolute joints with limits that did not allow any movement. This workaround way due to the lack of SDF support of fixed joints. Since we were not interested to have those joints in our models, they have been removed in 7ca06009f840f3e764be3a687f0db0a093182c62.
Recent version of SDFormat included fixed joints support, and the upstream iCub model has been updated accordingly. This PR adds again the FT fixed joints to the model of this repository.
Note that this PR solves few minor issues we had in this days:
The frames {r,l}_forearm and {r,l}_foot are back (before links were lumped together)
The gym-ignition method RobotJoints.joint_names() still do not have the fixed _ft_ joints (instead, using the previous upstream model, those joints were listed since they were transformed to revolute joints in the resulting SDF and gym-ignition treated them as regular revolute joints)
Pull request #1 added the model of the iCub humanoid robot. The model was adapted from the icub-models repository. Before https://github.com/robotology/icub-model-generator/pull/129 (read discussion in https://github.com/robotology/gym-ignition/issues/130), when the URDF was converted to SDF, the fixed joints of the upstream model used for the robot's FT sensors were transformed to revolute joints with limits that did not allow any movement. This workaround way due to the lack of SDF support of fixed joints. Since we were not interested to have those joints in our models, they have been removed in 7ca06009f840f3e764be3a687f0db0a093182c62.
Recent version of SDFormat included fixed joints support, and the upstream iCub model has been updated accordingly. This PR adds again the FT fixed joints to the model of this repository.
Note that this PR solves few minor issues we had in this days:
{r,l}_forearm
and{r,l}_foot
are back (before links were lumped together)RobotJoints.joint_names()
still do not have the fixed_ft_
joints (instead, using the previous upstream model, those joints were listed since they were transformed to revolute joints in the resulting SDF and gym-ignition treated them as regular revolute joints)