search

robotology / gz-sim-yarp-plugins

YARP plugins for Modern Gazebo (gz-sim).
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Enable `gz-sim-yarp-plugins-check-model` test on apt CI #191

Closed xela-95 closed 3 months ago

xela-95 commented 3 months ago

This PR enables the gz-sim-yarp-plugins-check-model test introduced in #179 and excluded from apt CI for an issue solved in #185.

xela-95 commented 3 months ago

Now it seems that this test is now passing also on apt.

traversaro commented 3 months ago

I suspect we could try (even in another PR) also to reduce the --repeat until-pass: settings, as many flaky failure I think could be due to the race condition fixed in https://github.com/robotology/gz-sim-yarp-plugins/pull/186 .

xela-95 commented 3 months ago

I suspect we could try (even in another PR) also to reduce the --repeat until-pass: settings, as many flaky failure I think could be due to the race condition fixed in #186 .

do you mean to remove the --repeat until-pass arguments in test for both apt CI and conda CI?

traversaro commented 3 months ago

I suspect we could try (even in another PR) also to reduce the --repeat until-pass: settings, as many flaky failure I think could be due to the race condition fixed in #186 .

do you mean to remove the --repeat until-pass arguments in test for both apt CI and conda CI?

It is something that we could try, but it is independent from this PR.

xela-95 commented 3 months ago

Merging! 🚀