search

robotology / icub-contrib-common

Meta-package to configure contrib modules and libraries
2 stars 2 forks source link

YARP_MODULE_PATH warning with YARP version >= 3.0.0 #8

Closed claudiofantacci closed 6 years ago

claudiofantacci commented 6 years ago

Starting from YARP 3.0.0, YARP_MODULE_PATH is deprecated and the YARP CMake modules are automatically included. See here.

As a consequence, if you use ICUBcontrib the following line spawns warning(s). https://github.com/robotology/icub-contrib-common/blob/a64acb1e501944d326b0e8c21af06640a7b16a64/templates/ICUBcontribConfig.cmake.in#L8

My suggestion for backward compatibility is to check whether YARP_VERSION_MAJOR LESS 3 and append YARP_MODULE_PATH or not.

pattacini commented 6 years ago

As discussed f2f, I'd better go for a full update in favor of YARP 3.0.0 without keeping backward compatibility.

Anyway, dealing with YARP_MODULE_PATH is still required somehow for finding ACE without YCM. Will clean this up soon.

claudiofantacci commented 6 years ago

That's ok @pattacini, we can sort this out together as soon as we have some time 😄 .

claudiofantacci commented 6 years ago

Thanks!