robotology / yarp

YARP - Yet Another Robot Platform
http://www.yarp.it
Other
527 stars 195 forks source link

NameServerContainer: do not print "database needs to be reset" message #3111

Closed traversaro closed 5 months ago

traversaro commented 5 months ago

The message "Database needs to be reset, IP or port number set." is printed every time the --ip or --socket is passed, so it does not make sense to print as an error as it is printed even if everything is working as intended. This PR changes it from yCError to yCInfo .

This seems a regression from https://github.com/robotology/yarp/commit/d97ab7f6269b16b94b7187269918e41746eee5c8#diff-be8b39c3c66ca00e0f5ace04995b0d08fc83edaaff870d6d8d87dc349d7cc8a8R104 . Before that commit, the message was just printed on stderr, but not printed as an error.

update-docs[bot] commented 5 months ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

traversaro commented 5 months ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

I think that the fix is minimal so probably it does not make sense to add a release note for this, @randaz81 if you like it feel free to let me know.

codacy-production[bot] commented 5 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +28.34% :white_check_mark: 0.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (71f6c8b1612f80a06c83d41f82b90b46d782fb86) | 535443 | 139764 | 26.10% | | | Head commit (4dc091a61efc8754199399a66c4026b8037fd326) | 112557 (-422886) | 61278 (-78486) | 54.44% (**+28.34%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3111) | 1 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more