robotology / yarp

YARP - Yet Another Robot Platform
http://www.yarp.it
Other
527 stars 195 forks source link

Install YARP_sig IDL headers #3136

Closed PeterBowman closed 2 months ago

PeterBowman commented 2 months ago

Follow-up to https://github.com/robotology/yarp/pull/3130. Regression caused by missing install rules:

 [ 72%] Building CXX object bindings/python/CMakeFiles/_roboticslab_vision_python.dir/roboticslab_visionPYTHON_wrap.cxx.o
In file included from /usr/local/include/yarp/dev/IAudioGrabberSound.h:11,
                 from /usr/local/include/yarp/dev/AudioGrabberInterfaces.h:11,
                 from /usr/local/include/yarp/dev/all.h:10,
                 from /__w/vision/vision/build/bindings/python/roboticslab_visionPYTHON_wrap.cxx:2817:
/usr/local/include/yarp/sig/AudioBufferSize.h:13:10: fatal error: yarp/sig/audioBufferSizeData.h: No such file or directory
   13 | #include <yarp/sig/audioBufferSizeData.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [bindings/python/CMakeFiles/_roboticslab_vision_python.dir/build.make:82: bindings/python/CMakeFiles/_roboticslab_vision_python.dir/roboticslab_visionPYTHON_wrap.cxx.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1417: bindings/python/CMakeFiles/_roboticslab_vision_python.dir/all] Error 2
gmake: *** [Makefile:160: all] Error 2

(CI run, 13_Compile vision.txt)

update-docs[bot] commented 2 months ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

randaz81 commented 2 months ago

Thank you @PeterBowman but this issue has already been fixed by https://github.com/robotology/yarp/pull/3137