robotology / yarp

YARP - Yet Another Robot Platform
http://www.yarp.it
Other
527 stars 195 forks source link

Fixed installation of yarp_sig header files #3137

Closed randaz81 closed 2 months ago

randaz81 commented 2 months ago

Added install of header files generated by thtift in yarp_sig

update-docs[bot] commented 2 months ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +28.12% :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9e4dfb74fc15e046d3a9e02fd863d614da38f698) | 538869 | 140607 | 26.09% | | | Head commit (a53da60ada23e9741b5f0635e2250f602bd6af91) | 113284 (-425585) | 61418 (-79189) | 54.22% (**+28.12%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3137) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

PeterBowman commented 2 months ago

https://github.com/robotology/yarp/blob/a53da60ada23e9741b5f0635e2250f602bd6af91/src/libYARP_sig/src/CMakeLists.txt#L192

@randaz81 shouldn't we also install private IDL headers, as in YARP_dev?

set_property(TARGET YARP_sig PROPERTY PRIVATE_HEADER ${YARP_sig_IMPL_HDRS} ${YARP_sig_idl_IMPL_HDRS}) 
PeterBowman commented 2 months ago

Would it be OK if I open a PR to patch this? It doesn't seem to cause trouble now, but I believe it might explode at some point later, and such tiny things are prone to being hard to debug.

Edit: see https://github.com/robotology/yarp/pull/3142.