Closed randaz81 closed 2 months ago
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>
, based on your changes.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +28.12% | :white_check_mark: ∅ |
Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more
@randaz81 shouldn't we also install private IDL headers, as in YARP_dev?
set_property(TARGET YARP_sig PROPERTY PRIVATE_HEADER ${YARP_sig_IMPL_HDRS} ${YARP_sig_idl_IMPL_HDRS})
Would it be OK if I open a PR to patch this? It doesn't seem to cause trouble now, but I believe it might explode at some point later, and such tiny things are prone to being hard to debug.
Edit: see https://github.com/robotology/yarp/pull/3142.
Added install of header files generated by thtift in yarp_sig