search

robotpy / examples

Repository of RobotPy example projects
43 stars 52 forks source link

rename example project folder names to match java but hyphenated #95

Closed fletch3555 closed 8 months ago

fletch3555 commented 9 months ago

I figured since we're going for parity, we might as well have consistency.

If we want full parity, I'm happy to switch this to no hyphens instead just like the java examples.

Thoughts?

fletch3555 commented 9 months ago

If we were to do this, there are a bunch of links to examples in frc-docs that also need to be updated.

... if others support support this renaming, then this is fine, but I don't feel strongly about it. Probably now is as good a time as any to make the change.

Perfectly fair. My OCD-tendencies like consistency, but it really wasn't much work at all so either way.

I was tempted to go the other way and remove the hyphens entirely, but I'd actually rather change the java side to match this if to be honest. I find this to be a bit more readable since we're keeping everything lowercase.

jasondaming commented 8 months ago

My opinion would be to either match the Java examples exactly or just leave it and be "better" in the future.

fletch3555 commented 8 months ago

My opinion would be to either match the Java examples exactly or just leave it and be "better" in the future.

I'm inclined to agree. The idea didn't come to me until I was committing these changes. I've now updated them to remove the hyphens. I still need to take a closer look to confirm they're all correct, but this should at least be 99% of it