search

robotpy / pyfrc

python3 library designed to make developing RobotPy-based code easier!
MIT License
50 stars 35 forks source link

Fix for #194: Create pre-deploy hooks? #195

Closed KenwoodFox closed 2 years ago

KenwoodFox commented 2 years ago

This is supposed to be a fix for #194, my idea is to implement a hooks.py that can be optionally included.

I dont like it quite as much as the always present .json idea @virtuald had because that would do all this automatically but perhaps its the better option. So id like to explore that too.

virtuald commented 2 years ago

It's an interesting idea. I am persuaded that separating the deployment data from the robot code is a good idea. However, it also seems that it's probable that if we were to allow custom metadata, does it really need to be dynamically generated? I guess I'd like to hear a usecase that isn't covered by our generic metadata in the other PR.

KenwoodFox commented 2 years ago

I could not think of a usecase, anything more advanced you might want to hook, can be done in a makefile (like what my team does rn)

I think the other pr with an included json may be more helpful