search

robrix / interval-functor

General purpose intervals of functors.
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Add instances Show1, Eq1, Ord1, NFData, Arbitrary, Series? #5

Open kindaro opened 4 years ago

kindaro commented 4 years ago

I would like to see some more classes defined for intervals. So far I have had a need of and defined the following:

It is mostly a triviality to define. I can make a pull request.

Arbitrary and Series incur dependencies that may not be acceptable for the user of the library. Possibly a small companion package can be added to the repository to encompass these.

robrix commented 4 years ago

I’m not keen on adding dependencies in general, but companion packages seem totally reasonable. NFData will require a deepseq dependency IIRC, but I don’t think I mind that one.

I don’t recognize Series; what package defines it?

kindaro commented 4 years ago

Actually it is Serial, my fault.

kindaro commented 4 years ago

@robrix  I put forward 2 pull requests, hopefully they are self-explanatory. I propose we move the conversation to the respective pull request tickets #7 and #8.