Closed gavv closed 1 month ago
Currently, when CI builds AAR, it uses libroc from master branch of roc-toolkit. It's not good because this way AAR builds are not reproducible.
What we need to do:
add ROC_VERSION parameter to android_docker.sh script; default value should be "master"; when cloning roc, checkout specified version
in release job on CI, specify ROC_VERSION explicitly, set it to roc-toolkit tag which is currently the latest
ROC_VERSION should support any git revision notation: tag name, branch name, or commit hash.
Fixed via #132.
gavv
commented
1 month ago gavv
commented
1 month ago
Currently, when CI builds AAR, it uses libroc from master branch of roc-toolkit. It's not good because this way AAR builds are not reproducible.
What we need to do:
add ROC_VERSION parameter to android_docker.sh script; default value should be "master"; when cloning roc, checkout specified version
in release job on CI, specify ROC_VERSION explicitly, set it to roc-toolkit tag which is currently the latest
ROC_VERSION should support any git revision notation: tag name, branch name, or commit hash.