Open gavv opened 1 year ago
we have gradle 6.4 https://github.com/roc-streaming/roc-java/blob/main/gradle/wrapper/gradle-wrapper.properties#L3 and it doesn't support java 17
Compatibility table: https://docs.gradle.org/current/userguide/compatibility.html
If we update gradle, will it still work on java 8? If yes, I'd suggest to update.
If we update gradle, will it still work on java 8?
I think so. Now it works with java 11.
The main problem is that maven plugin was removed from 7+ version. https://docs.gradle.org/current/userguide/upgrading_version_6.html#removal_of_the_legacy_maven_plugin
We using it for upload aar to maven central https://github.com/roc-streaming/roc-java/blob/main/android/roc-android/build.gradle#L2
But I guess it shouldn't be too hard to migrate to new maven-publish plugin :)
After fixing this, we'll need to add java17 step to CI jobs for linux and osx. Also we can switch release step to java17 too.
Currently, I'm able to build roc-java using OpenJDK 8, but not OpenJDK 17.
OpenJDK 8 is not available in next debian stable candidate, so it would be nice to fix build with recent version. Otherwise you need to install older JDK manually.
When using OpenJDK 17, I get the following error:
If I download JDK 8 from here and added it to PATH:
everything works.